feature: Improving Analyzer Failure State #2697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xoscar
commented
Jun 9, 2023
| @@ -45,36 +43,3 @@ func (l Linter) HasID() bool { | |||
| func (l Linter) GetID() id.ID { | |||
| return l.ID | |||
| } | |||
|
|
|||
| func (l Linter) ValidateResult(result model.LinterResult) error { | |||
There was a problem hiding this comment.
Not needed, clients will check score vs minimum score to validate it
xoscar
commented
Jun 9, 2023
| @@ -10,6 +10,8 @@ | |||
| package openapi | |||
|
|
|||
| type LinterResult struct { | |||
| MinimumScore int32 `json:"minimumScore,omitempty"` | |||
There was a problem hiding this comment.
We are now going to persis the minimum score that was used during the execution, not using the global
jorgeepc
approved these changes
Jun 9, 2023
| @@ -25,6 +25,7 @@ export const theme: DefaultTheme = { | |||
| md: '14px', | |||
| lg: '16px', | |||
| xl: '18px', | |||
| xxxl: '24px', | |||
There was a problem hiding this comment.
I don't know man, 20 should be xxl si I just went for it 😂
xoscar
deleted the
2682-analyzer-results-do-all-steps-of-a-test-rather-than-failing-on-an-analyzer-score-not-being-reached
branch
This was referenced Jun 12, 2023
mathnogueira
pushed a commit
that referenced
this pull request
Jun 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the way we handle error states for the analyzer. Instead of stopping the test execution, now clients will be reading the linter results to validate if there was a failure or not, and show the proper results.
Changes
Fixes
Checklist
https://www.loom.com/share/6624b56c915b4c41a07f52179bbbdbf7