Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cli): remove cli analytics #2716

Merged
merged 4 commits into from
Jun 15, 2023
Merged

fix(cli): remove cli analytics #2716

merged 4 commits into from
Jun 15, 2023

Conversation

jorgeepc
Copy link
Contributor

@jorgeepc jorgeepc commented Jun 12, 2023 •
edited
Loading

This PR removes the CLI analytics, including the --analytics flag from the configure command and the tracking of events.

Changes

  • remove --analytics flag from configure command
  • remove analytics.Track event
  • fix docs and examples

Fixes

Checklist

  • tested locally
  • added new dependencies
  • updated the docs
  • added a test

@jorgeepc jorgeepc added the CLI label Jun 12, 2023
@jorgeepc jorgeepc self-assigned this Jun 12, 2023
@jorgeepc jorgeepc marked this pull request as ready for review June 13, 2023 18:15
xoscar
xoscar approved these changes Jun 15, 2023
View reviewed changes
Copy link
Contributor

@xoscar xoscar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jorgeepc jorgeepc merged commit 0419ba2 into main Jun 15, 2023
@jorgeepc jorgeepc deleted the fix-remove-cli-analytics branch June 15, 2023 16:53
mathnogueira pushed a commit that referenced this pull request Jun 19, 2023
@jorgeepc @mathnogueira
fix(cli): remove cli analytics (#2716)
3ab650a
mathnogueira pushed a commit that referenced this pull request Jun 19, 2023
@jorgeepc @mathnogueira
fix(cli): remove cli analytics (#2716)
24c5dcc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielbdias danielbdias danielbdias approved these changes

@xoscar xoscar xoscar approved these changes

Assignees

@jorgeepc jorgeepc

Labels
CLI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jorgeepc @xoscar @danielbdias