Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(frontend): fix build warnings related to typescript version #3009

Merged
merged 1 commit into from
Jul 31, 2023
Merged

fix(frontend): fix build warnings related to typescript version #3009

merged 1 commit into from
Jul 31, 2023

Conversation

jorgeepc
Copy link
Contributor

This PR fixes some build warnings in our web app related to a typescript conflict with a nested package.

warnings:

TypeError: Cannot set property mark of #<Object> which has only a getter
TypeError: Cannot set property mark of #<Object> which has only a getter
    at Object.connectTypeScriptPerformance

See TypeStrong/fork-ts-checker-webpack-plugin#797

Changes

  • remove storybook packages causing issues

Fixes

Checklist

  • tested locally
  • added new dependencies
  • updated the docs
  • added a test

@jorgeepc jorgeepc self-assigned this Jul 31, 2023
@jorgeepc jorgeepc requested a review from xoscar July 31, 2023 17:28
@jorgeepc jorgeepc marked this pull request as ready for review July 31, 2023 17:29
danielbdias
danielbdias reviewed Jul 31, 2023
View reviewed changes
web/package.json
Comment on lines -84 to -85
"storybook": "start-storybook -p 6006 -s public",
"build-storybook": "build-storybook -s public",
Copy link
Contributor

@danielbdias danielbdias Jul 31, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sad to see the storybook getting rid of the project (I used it a lot in other projects before to test component behaviors), but right now, that makes sense.

Today it is easier to build a component and test it with our UI pointing to an example API than creating a story and mocking many things.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exactly, storybook is great but is not useful at this point, in the future if makes sense we can add it back again

@jorgeepc jorgeepc merged commit 6a720f3 into main Jul 31, 2023
@jorgeepc jorgeepc deleted the fix/web-build-warnings-typescript branch July 31, 2023 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielbdias danielbdias danielbdias approved these changes

@xoscar xoscar xoscar approved these changes

Assignees

@jorgeepc jorgeepc

Labels
frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jorgeepc @xoscar @danielbdias