Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(frontend): fix method to parse url #3127

Merged
merged 1 commit into from
Sep 6, 2023
Merged

fix(frontend): fix method to parse url #3127

merged 1 commit into from
Sep 6, 2023

Conversation

jorgeepc
Copy link
Contributor

@jorgeepc jorgeepc commented Sep 6, 2023 •
edited
Loading

This PR fixes a FE bug with the Url Docker Suggestion component. It was causing the web app to stop responding when using some specific URLs in your test definition.

Changes

  • remove url regex validation

Fixes

Checklist

  • tested locally
  • added new dependencies
  • updated the docs
  • added a test

@jorgeepc jorgeepc self-assigned this Sep 6, 2023
@jorgeepc jorgeepc marked this pull request as ready for review September 6, 2023 18:08
@jorgeepc jorgeepc changed the title fix(frontend): remove regex to validate url fix(frontend): fix method to parse url Sep 6, 2023
@jorgeepc jorgeepc mentioned this pull request Sep 6, 2023
Closed
@jorgeepc jorgeepc merged commit 3c5196c into main Sep 6, 2023
31 checks passed
@jorgeepc jorgeepc deleted the fix-url-regex branch September 6, 2023 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xoscar xoscar xoscar approved these changes

Assignees

@jorgeepc jorgeepc

Labels
frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ui hung on detailed run and pathPrefix issue
2 participants
@jorgeepc @xoscar