Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(server): splitting trace poller in multiple queues #3133

Merged
merged 30 commits into from
Sep 15, 2023

Conversation

danielbdias
Copy link
Contributor

@danielbdias danielbdias commented Sep 7, 2023

This PR breaks the trace poller logic into three phases: start, fetch and evaluate. Each step has its own worker now on package executor/tracepollerworker.

The old trace poller code still exists and will be removed in future versions.

Loom: https://www.loom.com/share/0bcb3cf33c0b472f993c7e891af78361

Changes

  • Added executor/tracepollerworker package
  • Updated dogfooding tests to consider the three phases
  • Fixed some race conditions that were causing trace poller to crash

Checklist

  • tested locally
  • added new dependencies
  • updated the docs
  • added a test

@danielbdias danielbdias force-pushed the fix/split-tracepoller-queues branch 4 times, most recently from 62b0aab to 1c9687a Compare September 12, 2023 15:19
@danielbdias danielbdias changed the title wip - isolating trace poller start chore(server): splitting trace poller in multiple queues Sep 12, 2023
@danielbdias danielbdias force-pushed the fix/split-tracepoller-queues branch from e864826 to 973adc6 Compare September 13, 2023 12:16
@danielbdias danielbdias merged commit 082bbda into main Sep 15, 2023
38 checks passed
@danielbdias danielbdias deleted the fix/split-tracepoller-queues branch September 15, 2023 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants