-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(server): splitting trace poller in multiple queues #3133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielbdias
force-pushed
the
fix/split-tracepoller-queues
branch
4 times, most recently
from
September 12, 2023 15:19
62b0aab
to
1c9687a
Compare
danielbdias
changed the title
wip - isolating trace poller start
chore(server): splitting trace poller in multiple queues
Sep 12, 2023
danielbdias
force-pushed
the
fix/split-tracepoller-queues
branch
from
September 13, 2023 12:16
e864826
to
973adc6
Compare
danielbdias
requested review from
schoren,
mathnogueira,
jorgeepc and
xoscar
September 15, 2023 14:30
schoren
approved these changes
Sep 15, 2023
mathnogueira
approved these changes
Sep 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR breaks the trace poller logic into three phases:
start
,fetch
andevaluate
. Each step has its own worker now on packageexecutor/tracepollerworker
.The old trace poller code still exists and will be removed in future versions.
Loom: https://www.loom.com/share/0bcb3cf33c0b472f993c7e891af78361
Changes
executor/tracepollerworker
packageChecklist