Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(server): allow analytics cfg override #3186

Merged
merged 1 commit into from
Sep 26, 2023
Merged

fix(server): allow analytics cfg override #3186

merged 1 commit into from
Sep 26, 2023

Conversation

xoscar
Copy link
Contributor

@xoscar xoscar commented Sep 25, 2023 •
edited
Loading

This PR updates the server config to allow analytics keys to override the ones provided during compilation.

Changes

  • Adds new analytics environment flags
  • Overrides feature flags from the app config

Checklist

  • tested locally
  • added new dependencies
  • updated the docs
  • added a test

@xoscar xoscar marked this pull request as ready for review September 26, 2023 15:12
@xoscar xoscar requested a review from jorgeepc September 26, 2023 15:12
@xoscar xoscar merged commit c845a30 into main Sep 26, 2023
38 checks passed
@xoscar xoscar deleted the fix/analytics-cfg-override branch September 26, 2023 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorgeepc jorgeepc jorgeepc approved these changes

@schoren schoren Awaiting requested review from schoren

@mathnogueira mathnogueira Awaiting requested review from mathnogueira

@danielbdias danielbdias Awaiting requested review from danielbdias

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xoscar @jorgeepc