Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: http metric middleware improvements #3284

Merged
merged 2 commits into from
Oct 21, 2023
Merged

fix: http metric middleware improvements #3284

merged 2 commits into from
Oct 21, 2023

Conversation

mathnogueira
Copy link
Contributor

This PR achieves two things:

  1. Make sure GET / endpoint calls are collected with the correct http.route. Today it's considered empty
  2. Use attributes.Set for recording the metric attributes (it's recommended by OpenTelemetry due to performance)

Checklist

  • tested locally
  • added new dependencies
  • updated the docs
  • added a test

Loom video

Add your loom video here if your work can be visualized

@mathnogueira mathnogueira merged commit 6dea0e3 into main Oct 21, 2023
38 checks passed
@mathnogueira mathnogueira deleted the fix/http-metric-middleware branch October 21, 2023 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielbdias danielbdias danielbdias approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mathnogueira @danielbdias