Fix agent docker #3288
Merged
Fix agent docker #3288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the agent to run in docker. The problem was a validation (version match)that was being skipped if the env
TRACETEST_DEVwas set. In docker, the env is not set, so it always tried to do the check. However that check happens before other params are loaded (like endpoint) so the only way for that check to pass is having a config.yaml file, which is not present on docker. Removing that check makes things work againI also modified the entrypoint of the docker image so it allows passing extra parameters to the agent.
Changes
Fixes
Checklist