Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: added support to unauthorized error #3292

Merged
merged 1 commit into from
Oct 25, 2023
Merged

fix: added support to unauthorized error #3292

merged 1 commit into from
Oct 25, 2023

Conversation

danielbdias
Copy link
Contributor

@danielbdias danielbdias commented Oct 25, 2023 •
edited
Loading

This PR improves the error handling on CLI to tell the users when they are not authenticated on the Tracetest server.

image

Changes

  • Update error handling for 401 errors on CLI

Checklist

  • tested locally
  • added new dependencies
  • updated the docs
  • added a test

xoscar
xoscar approved these changes Oct 25, 2023
View reviewed changes
Copy link
Contributor

@xoscar xoscar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GJ!

@danielbdias danielbdias merged commit 2296535 into main Oct 25, 2023
38 checks passed
@danielbdias danielbdias deleted the fix/unauthenticated-error branch October 25, 2023 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xoscar xoscar xoscar approved these changes

@jorgeepc jorgeepc jorgeepc approved these changes

@schoren schoren Awaiting requested review from schoren

@mathnogueira mathnogueira Awaiting requested review from mathnogueira

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@danielbdias @jorgeepc @xoscar