chore: Migrate start actions from CLI to agent #3378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathnogueira
approved these changes
Nov 20, 2023
jorgeepc
approved these changes
Nov 20, 2023
| @@ -0,0 +1,192 @@ | |||
| package ui | |||
There was a problem hiding this comment.
Question, why not reusing what we have in cli/ui?
There was a problem hiding this comment.
Good question! I'm not using cli/ui to avoid a dependency of cli -> agent. I'll unify them in the next PR, moving to a shared package.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR starts to decouple the agent from the CLI. Here, we are removing the old
cmdcommand for the agent (because this responsibility should be to the CLI), and thestarterandconfig flagsare being moved to the agent because it is related to the agent business logic.Checklist