fix(frontend): fix bug in test specs virtual list #3657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
xoscar
approved these changes
Feb 19, 2024
| @@ -57,7 +57,10 @@ export const Selector = styled.div` | |||
|
|
|||
| export const Title = styled(Typography.Text)` | |||
| color: ${({theme}) => theme.color.text}; | |||
| font-family: monospace; | |||
There was a problem hiding this comment.
Why do we need this font-family change here?
|
|
||
| const getItemSize = useCallback( | ||
| index => { | ||
| const item = assertionResults?.resultList?.[index]; |
There was a problem hiding this comment.
I believe we should add some comments about what is going here, why do we need this etc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug with the implementation of the virtual list for
Test Specs. A test spec item has a variable height, and for that reason we need to implement theVariableSizeListcomponent with a strategy to provide the item height as part of the render cycle.Changes
Fixes
Checklist
Screenshots
Before
Now