Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(frontend): add getPublicInfo for tracing backend #3689

Merged
merged 1 commit into from
Feb 27, 2024
Merged

feat(frontend): add getPublicInfo for tracing backend #3689

merged 1 commit into from
Feb 27, 2024

Conversation

jorgeepc
Copy link
Contributor

This PR adds the getPublicInfo for the tracing backend service.

Changes

  • new getPublicInfo method

Fixes

Checklist

  • tested locally
  • added new dependencies
  • updated the docs
  • added a test

@jorgeepc jorgeepc self-assigned this Feb 26, 2024
@vercel Vercel
Copy link

vercel bot commented Feb 26, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
tracetest ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 26, 2024 10:46pm

@jorgeepc jorgeepc marked this pull request as ready for review February 26, 2024 23:25
xoscar
xoscar approved these changes Feb 27, 2024
View reviewed changes
Copy link
Contributor

@xoscar xoscar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, the filtering might be a little bit weird as the function says getPublicInfo but we are pretty much getting everything from the BE, we can decide later on if there is something we can do on that end

@jorgeepc jorgeepc merged commit 9bfa704 into main Feb 27, 2024
39 checks passed
@jorgeepc jorgeepc deleted the feat-public-info-tracing-backend-method branch February 27, 2024 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xoscar xoscar xoscar approved these changes

Assignees

@jorgeepc jorgeepc

Labels
frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jorgeepc @xoscar