feat(frontend): Resizable Panels for the Test run #3694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@xoscar I like everything related to behaviour included how you made minimal width for resizable sections. But regarding visual styles - i would ask you to leave our current one. In your version, these elements attract a lot of attention on the page, but this is just a secondary functionality that should improve the user's work when necessary.
|
|
and examples for automate tab: |
jorgeepc
reviewed
Feb 28, 2024
There was a problem hiding this comment.
Hey @xoscar great job! The code looks good to me. I have a couple of comments:
- I see a
web/src/components/RunDetailAutomate/TechniquesPanel.tsxempty file. Should we delete it? - Did you validate that the resize functionality works correct with the virtual list? We have a virtual list in the test specs. Let's double check that is working as expected.
- I'm not a big fan of the new UI header to close/open the panels. Let's work with @olha23 in a proposal for that.
|
@xoscar looks great, thanks! |
jorgeepc
approved these changes
Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the style of the resizable panels for the test run tabs, allowing users to drag the panels to their choice depending on what they want to focus on
Changes
Fixes
Checklist
Loom video
https://www.loom.com/share/788dc005396f4a13aadff3e549bf8021