Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(traces): fixing missing span attributes #4014

Merged
merged 3 commits into from
Sep 10, 2024
Merged

fix(traces): fixing missing span attributes #4014

merged 3 commits into from
Sep 10, 2024

Conversation

xoscar
Copy link
Contributor

@xoscar xoscar commented Sep 10, 2024

This PR adds the missing span attributes such as

  1. Service name
  2. Resource spans

Changes

  • Adds resources attribute to base spans
  • Adds service name attribute

Fixes

Checklist

  • tested locally
  • added new dependencies
  • updated the docs
  • added a test

@xoscar xoscar self-assigned this Sep 10, 2024
@vercel Vercel
Copy link

vercel bot commented Sep 10, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
tracetest ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 10, 2024 10:14pm

@xoscar xoscar marked this pull request as ready for review September 10, 2024 21:54
@xoscar xoscar merged commit 4935bdd into main Sep 10, 2024
38 checks passed
@xoscar xoscar deleted the fix-missing-attributes branch September 10, 2024 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorgeepc jorgeepc jorgeepc approved these changes

Assignees

@xoscar xoscar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xoscar @jorgeepc