[KEP-0009] feat: add expression based assertions #576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
porridge
requested changes
Nov 25, 2024
eddycharly
reviewed
Nov 25, 2024
pkg/test/utils/kubernetes.go
Outdated
| variables[resourceRef.Id] = referencedResource.Object | ||
| } | ||
|
|
||
| env, err := cel.NewEnv() |
There was a problem hiding this comment.
Calling cel.NewEnv() may not be enough, you probably want to enable a couple of options/libs.
There was a problem hiding this comment.
@eddycharly any hints on what might be useful? 🤔
eddycharly
reviewed
Nov 25, 2024
kumar-mallikarjuna
force-pushed
the
KEP-0009
branch
2 times, most recently
from
0fe748e to
a85752a
Compare
porridge
requested changes
Dec 3, 2024
|
Thanks for the quick review @porridge . I'll add the tests tomorrow. |
porridge
requested changes
Dec 10, 2024
This PR adds CEL-expression based assertions to `TestAsserts`. See https://github.com/kudobuilder/kuttl/blob/main/keps/0009-expression-based-assertions.md for more details. Signed-off-by: Kumar Mallikarjuna <[email protected]>
Signed-off-by: Kumar Mallikarjuna <[email protected]>
Signed-off-by: Kumar Mallikarjuna <[email protected]>
Signed-off-by: Kumar Mallikarjuna <[email protected]>
Signed-off-by: Kumar Mallikarjuna <[email protected]>
Signed-off-by: Kumar Mallikarjuna <[email protected]>
…re present Signed-off-by: Kumar Mallikarjuna <[email protected]>
Signed-off-by: Kumar Mallikarjuna <[email protected]>
Signed-off-by: Kumar Mallikarjuna <[email protected]>
Signed-off-by: Kumar Mallikarjuna <[email protected]>
Signed-off-by: Kumar Mallikarjuna <[email protected]>
Signed-off-by: Kumar Mallikarjuna <[email protected]>
Signed-off-by: Kumar Mallikarjuna <[email protected]>
Signed-off-by: Kumar Mallikarjuna <[email protected]>
Signed-off-by: Kumar Mallikarjuna <[email protected]>
Signed-off-by: Kumar Mallikarjuna <[email protected]>
Signed-off-by: Kumar Mallikarjuna <[email protected]>
Signed-off-by: Kumar Mallikarjuna <[email protected]>
Signed-off-by: Kumar Mallikarjuna <[email protected]>
Signed-off-by: Kumar Mallikarjuna <[email protected]>
Signed-off-by: Kumar Mallikarjuna <[email protected]>
…pace Signed-off-by: Kumar Mallikarjuna <[email protected]>
Signed-off-by: Kumar Mallikarjuna <[email protected]>
kumar-mallikarjuna
force-pushed
the
KEP-0009
branch
from
7044f54 to
a7122a6
Compare
porridge
requested changes
Dec 19, 2024
...gration_test_data/assert_expressions/check_expression_for_ephemeral_namespace/01-assert.yaml
Outdated
Show resolved
Hide resolved
...gration_test_data/assert_expressions/check_expression_for_ephemeral_namespace/00-create.yaml
Outdated
Show resolved
Hide resolved
pkg/test/utils/kubernetes.go
Outdated
| variables[resourceRef.Id] = referencedResource.Object | ||
| } | ||
|
|
||
| env, err := cel.NewEnv() |
There was a problem hiding this comment.
@eddycharly any hints on what might be useful? 🤔
Signed-off-by: Kumar Mallikarjuna <[email protected]>
kumar-mallikarjuna
force-pushed
the
KEP-0009
branch
from
1752619 to
32bcb9c
Compare
Signed-off-by: Kumar Mallikarjuna <[email protected]>
Signed-off-by: Kumar Mallikarjuna <[email protected]>
porridge
requested changes
Jan 2, 2025
|
|
||
| for i := 0; i < len(files)-1; i++ { | ||
| fName := fmt.Sprintf("%s/%s", dirName, files[i].Name()) | ||
| step := buildTestStep(t) |
There was a problem hiding this comment.
Only now I realized there is a separate step object for every file, and that this logic makes certain expectations about directory content. Also the directories look like kuttl tests but the test semantics are somewhat different.
Since the invalid expression case contains just one file, and all cases are effectively a single step, how about:
- using a single
stepobject per test, - with a bunch of
LoadYAMLcalls, each using the sameexpectLoadFailurecheck - and with a single
step.Runcall - and drop the numeric prefix from filenames to avoid implying that there can be multiple steps.
There was a problem hiding this comment.
and all cases are effectively a single step
check_expression_for_ephemeral_namespace has two steps so I wanted to keep an inclusive logic 🤔
...gration_test_data/assert_expressions/check_expression_for_ephemeral_namespace/01-assert.yaml
Outdated
Show resolved
Hide resolved
Signed-off-by: Kumar Mallikarjuna <[email protected]>
Signed-off-by: Kumar Mallikarjuna <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR adds CEL-expression based assertions to
TestAsserts. See https://github.com/kudobuilder/kuttl/blob/main/keps/0009-expression-based-assertions.md for more details.Fixes #562