-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Django 1.9 #21
Comments
So the issue above was fixed by encode/django-rest-framework#3785, which is in django-rest-framework 3.3.3+. However running the tests still fails with exceptions like:
And then after adding
And then after also adding
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
#20 will shortly add Django 1.9 to the Travis run, but marked as allowed to fail, since the tests are currently failing, eg:
https://travis-ci.org/kumar303/hawkrest/jobs/101117531
This appears to be due to Django 1.9 now not allowing models to be imported in
__init__.py
, per:https://docs.djangoproject.com/en/1.7/internals/deprecation/#deprecation-removed-in-1-9
However due to a bug, the deprecation warning for this wasn't shown when using previous versions of Django, otherwise the failure mode would have been more clear:
https://code.djangoproject.com/ticket/25477
Whilst hawkrest doesn't have any models itself, it imports several rest_framework classes which do import some of the rest_framework's models.
Once support for Django 1.9 is added, the
allow_failure
lines in.travis.yml
can be removed.The text was updated successfully, but these errors were encountered: