fix: wrong builder metrics flag (#319)

Fixes: * Change Mev boost Builder metrics flags. Using `--metrics.builder=true` cause this flag to be considered as `false` and making builder metrics to not being recorded. * Fix early return on https://github.com/kurtosis-tech/ethereum-package/blob/main/main.star#L236-L242 causing the execution to finish before adding the additional services. --------- Co-authored-by: Gyanendra Mishra <[email protected]>
ethpandaops · Oct 19, 2023 · 51a4422 · 51a4422
1 parent 946fbf0
commit 51a4422
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/main.star b/main.star
@@ -233,6 +233,7 @@ def run(plan, args={}):
                 )
                 all_mevboost_contexts.append(mev_boost_context)
 
+    if len(args_with_right_defaults.additional_services) == 0:
         output = struct(
             all_participants=all_participants,
             final_genesis_timestamp=final_genesis_timestamp,

diff --git a/src/package_io/input_parser.star b/src/package_io/input_parser.star
@@ -518,7 +518,7 @@ def enrich_mev_extra_params(parsed_arguments_dict, mev_prefix, mev_port, mev_typ
                     ),
                     '--miner.extradata="Illuminate Dmocratize Dstribute"',
                     "--builder.algotype=greedy",
-                    "--metrics.builder=true",
+                    "--metrics.builder",
                 ]
                 + parsed_arguments_dict["mev_params"]["mev_builder_extra_args"],
                 "el_extra_env_vars": {