fix: Improve MEV setup to use less containers for non_validator nodes (…

…#224) Co-authored-by: Kamil Chodoła <[email protected]>
ethpandaops · Sep 26, 2023 · bd176f0 · bd176f0
1 parent 37dccce
commit bd176f0
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 21 deletions.
diff --git a/main.star b/main.star
@@ -198,20 +198,21 @@ def run(plan, args={}):
     all_mevboost_contexts = []
     if mev_endpoints:
         for index, participant in enumerate(all_participants):
-            mev_boost_launcher = mev_boost_launcher_module.new_mev_boost_launcher(
-                MEV_BOOST_SHOULD_CHECK_RELAY, mev_endpoints
-            )
-            mev_boost_service_name = "{0}{1}".format(
-                parse_input.MEV_BOOST_SERVICE_NAME_PREFIX, index
-            )
-            mev_boost_context = mev_boost_launcher_module.launch(
-                plan,
-                mev_boost_launcher,
-                mev_boost_service_name,
-                network_params.network_id,
-                mev_params.mev_boost_image,
-            )
-            all_mevboost_contexts.append(mev_boost_context)
+            if args_with_right_defaults.participants[index].validator_count != 0:
+                mev_boost_launcher = mev_boost_launcher_module.new_mev_boost_launcher(
+                    MEV_BOOST_SHOULD_CHECK_RELAY, mev_endpoints
+                )
+                mev_boost_service_name = "{0}{1}".format(
+                    parse_input.MEV_BOOST_SERVICE_NAME_PREFIX, index
+                )
+                mev_boost_context = mev_boost_launcher_module.launch(
+                    plan,
+                    mev_boost_launcher,
+                    mev_boost_service_name,
+                    network_params.network_id,
+                    mev_params.mev_boost_image,
+                )
+                all_mevboost_contexts.append(mev_boost_context)
 
     if not args_with_right_defaults.launch_additional_services:
         return

diff --git a/src/package_io/parse_input.star b/src/package_io/parse_input.star
@@ -194,8 +194,6 @@ def enrich_mev_extra_params(parsed_arguments_dict, mev_prefix, mev_port, mev_typ
     num_participants = len(parsed_arguments_dict["participants"])
 
     if mev_type == "full":
-        mev_url = "http://{0}{1}:{2}".format(mev_prefix, num_participants, mev_port)
-
         mev_participant = {
             "el_client_type": "geth",
             # TODO replace with actual when flashbots/builder is published
@@ -206,7 +204,6 @@ def enrich_mev_extra_params(parsed_arguments_dict, mev_prefix, mev_port, mev_typ
             "cl_client_image": "sigp/lighthouse",
             "cl_client_log_level": "",
             "beacon_extra_params": [
-                "--builder={0}".format(mev_url),
                 "--always-prepare-payload",
                 "--prepare-payload-lookahead",
                 "12000",
@@ -231,11 +228,9 @@ def enrich_mev_extra_params(parsed_arguments_dict, mev_prefix, mev_port, mev_typ
                 "BUILDER_TX_SIGNING_KEY": "0x"
                 + genesis_constants.PRE_FUNDED_ACCOUNTS[0].private_key
             },
-            "validator_extra_params": ["--builder-proposals"],
+            "validator_extra_params": [],
             "builder_network_params": None,
-            "validator_count": package_io_parser.default_network_params()[
-                "num_validator_keys_per_node"
-            ],
+            "validator_count": 0,
         }
 
         parsed_arguments_dict["participants"].append(mev_participant)