Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: counting by summing each participant #112

Merged
merged 2 commits into from
Aug 2, 2023
Merged

Conversation

adschwartz
Copy link
Contributor

@adschwartz adschwartz commented Jul 31, 2023

This PR changes the way we count the actual number of validators by summing counts for each participant and multiplying by the number of validator keys per node.

Resolves #111

Changelog picked up from commits here:

feat: counting by summing each participant

@adschwartz adschwartz requested a review from mieubrisse August 1, 2023 14:01
Copy link
Contributor

@barnabasbusa barnabasbusa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adschwartz adschwartz merged commit f9b638b into main Aug 2, 2023
@adschwartz adschwartz deleted the anders/new-count branch August 2, 2023 20:43
h4ck3rk3y added a commit that referenced this pull request Sep 4, 2023
🤖 I have created a release *beep* *boop*
---


##
[0.3.0](0.2.0...0.3.0)
(2023-09-03)


### ⚠ BREAKING CHANGES

* Uses the `plan` object. Users will have to update their Kurtosis CLI
to >= 0.63.0 and restart the engine

### Features

* add beacon-metrics-gazer + beacon-metrics-gazer grafana dashboard
([#114](#114))
([5540587](5540587))
* add deneb support
([#96](#96))
([07ed500](07ed500))
* add ethereumjs to nightly runners
([b86d886](b86d886))
* add ethereumjs to nightly runners
([#154](#154))
([b86d886](b86d886))
* add forkmon
([#107](#107))
([2a8ad19](2a8ad19))
* add light-beaconchain-explorer
([83e01a1](83e01a1))
* add light-beaconchain-explorer
([#125](#125))
([83e01a1](83e01a1))
* add multiple endpoint support for lightbeaconchain expolorer
([#151](#151))
([68572cd](68572cd))
* counting by summing each participant
([f9b638b](f9b638b))
* counting by summing each participant
([#112](#112))
([f9b638b](f9b638b))
* disable login for grafana
([4d7df4b](4d7df4b))
* disable login for grafana
([#122](#122))
([4d7df4b](4d7df4b))
* **formatting:** Add editorconfig, move everything to using tabs (4)
([#106](#106))
([cb0fc69](cb0fc69))
* launch the mock mev builder
([#94](#94))
([7fcd3e2](7fcd3e2))
* make it possible to have capella on epoch 0 or non 0
([#108](#108))
([1133497](1133497))
* make mev more configurable
([#164](#164))
([0165ef1](0165ef1))
* parameterize mev_boost and mev_builder images
([#171](#171))
([28adec1](28adec1))
* snooper support
([#121](#121))
([d2cccf4](d2cccf4))
* support full MEV
([#115](#115))
([e9e8c41](e9e8c41))
* use eth-network-package to spin up participant network
([#90](#90))
([91029ac](91029ac))


### Bug Fixes

* a bug around participants
([#129](#129))
([9382767](9382767))
* delay deneb to 500 epoch
([#102](#102))
([d07270b](d07270b))
* dont spin up extra el/cl client for mock-mev
([#158](#158))
([46d67fc](46d67fc))
* fix an arg parsing bug
([#135](#135))
([f084e7c](f084e7c))
* fix passed argument parsing
([#85](#85))
([a5d40e9](a5d40e9))
* fixed teku validator params for MEV
([#149](#149))
([b0079cf](b0079cf))
* fixing nimbus payload url
([#155](#155))
([55c1f59](55c1f59))
* geth failing after ethash package removal
([#93](#93))
([41e3d2c](41e3d2c)),
closes [#91](#91)
* make besu a bootnode
([29296cd](29296cd))
* make besu a bootnode
([#146](#146))
([29296cd](29296cd))
* make this work with kurtosis 0.65.0
([#73](#73))
([13c72ec](13c72ec))
* mention reth in package readme
([#133](#133))
([d11a689](d11a689))
* move parallel keystore generation to global config
([0789eed](0789eed))
* move parallel keystore generation to global config
([#130](#130))
([0789eed](0789eed))
* nightly tests that rely on etherejums get the right image
([#159](#159))
([97b4d33](97b4d33))
* Nimbus can't run when slot time is below 12s
([#100](#100))
([c38bff9](c38bff9))
* pass right mev-boost url to teku
([#147](#147))
([8bb75d9](8bb75d9))
* pin postgres package
([#174](#174))
([6b8d9d3](6b8d9d3))
* Remove nethermind restriction
([#126](#126))
([373c6c9](373c6c9))
* Switch default images to latest
([#99](#99))
([4a85c9d](4a85c9d))
* Update enclave name flag
([#87](#87))
([6531a7a](6531a7a))
* update genesis generator to support netherminds new format
([#68](#68))
([094352d](094352d))
* update nightly runner
([#163](#163))
([4eba65d](4eba65d))
* use eth maintained tx-fuzz
([#110](#110))
([b0903bd](b0903bd))
* use flashbots builder
([#162](#162))
([7a0c2d0](7a0c2d0))
* use mev-boost-relay by flashbots
([#141](#141))
([fca62fc](fca62fc))
* use named artifacts
([#69](#69))
([968f073](968f073)),
closes [#70](#70)
* Use plan object
([#65](#65))
([8e5d185](8e5d185))
* use v2 endoint to get the head block
([#153](#153))
([f084711](f084711))
* work with latest eth-network-package
([14dc957](14dc957))
* work with latest eth-network-package
([#116](#116))
([14dc957](14dc957))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Gyanendra Mishra <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

count is not considered when doing the check for actual_num_validators
3 participants