Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add generic prometheus endpoints #209

Merged

Conversation

cbermudez97
Copy link
Contributor

  • feat: add execution and additional metrics jobs to prometheus service
  • feat: add beacon metrics gazer to prometheus
  • fix: ignore not defined metrics info

@cbermudez97 cbermudez97 changed the title Add Generic Prometheus Endpoints feat: add generic prometheus endpoints Sep 20, 2023
@cbermudez97 cbermudez97 marked this pull request as draft September 20, 2023 14:59
@cbermudez97 cbermudez97 marked this pull request as ready for review September 20, 2023 15:41
Copy link
Collaborator

@h4ck3rk3y h4ck3rk3y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks for contributing

  1. Do we have Grafana dashboards for the EL metrics?
  2. Have you tested if Grafana works properly for CL clients

src/prometheus/prometheus_launcher.star Outdated Show resolved Hide resolved
src/prometheus/prometheus_launcher.star Outdated Show resolved Hide resolved
src/prometheus/prometheus_launcher.star Outdated Show resolved Hide resolved
src/prometheus/prometheus_launcher.star Outdated Show resolved Hide resolved
src/prometheus/prometheus_launcher.star Outdated Show resolved Hide resolved
@cbermudez97
Copy link
Contributor Author

LGTM thanks for contributing

  1. Do we have Grafana dashboards for the EL metrics?
  2. Have you tested if Grafana works properly for CL clients

@h4ck3rk3y Uploaded fixes for your comments and an issue with the beacon metrics gazer job. Tested it and EL and CL clients are correctly loaded on Prometheus. There are no dashboards on Grafana for EL yet but the metrics can be used with the Explore tab for visualization.

main.star Show resolved Hide resolved
main.star Show resolved Hide resolved
@cbermudez97 cbermudez97 force-pushed the feat/add-generic-prometheus-endpoints branch from c481e77 to 7e6dc72 Compare September 27, 2023 15:51
main.star Show resolved Hide resolved
@h4ck3rk3y h4ck3rk3y merged commit d04e85f into ethpandaops:main Sep 27, 2023
@cbermudez97 cbermudez97 deleted the feat/add-generic-prometheus-endpoints branch September 27, 2023 16:15
h4ck3rk3y pushed a commit that referenced this pull request Sep 28, 2023
🤖 I have created a release *beep* *boop*
---


##
[0.5.0](0.4.0...0.5.0)
(2023-09-28)


### ⚠ BREAKING CHANGES

* rename the package to ethereum-package
([#234](#234))

### Features

* add generic prometheus endpoints
([#209](#209))
([d04e85f](d04e85f))


### Bug Fixes

* add an MIT licence
([#246](#246))
([f632ff1](f632ff1))
* make nimbus work with mev components
([#244](#244))
([5c64ed5](5c64ed5))


### Code Refactoring

* rename the package to ethereum-package
([#234](#234))
([23e4d5e](23e4d5e))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants