fix: rename light-beaconchain-explorer to dora-the-explorer & change db location #243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
h4ck3rk3y
approved these changes
Sep 28, 2023
h4ck3rk3y
pushed a commit
that referenced
this pull request
Sep 28, 2023
🤖 I have created a release *beep* *boop* --- ## [0.5.1](0.5.0...0.5.1) (2023-09-28) ### Bug Fixes * enable all apis for reth ([#241](#241)) ([db92f7b](db92f7b)) * rename light-beaconchain-explorer to dora-the-explorer & change db location ([#243](#243)) ([d3a4b49](d3a4b49)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The lightweight beaconchain explorer was renamed to
dora(Dora the Explorer).This PR renames all explorer related variables & references accordingly.
I've also changed the explorer db path to a local file instead of the
:memory:placeholder.The in-memory database caused issues as the content is being wiped when all db connections are being closed.
I've just used
/dora-database.sqliteas path. Maybe some of you can give feedback if that's the right location for it :)Replacement for #219, as the renaming has been reworked in a new branch