Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use prometheus kurtosis package #399

Merged
merged 4 commits into from
Dec 12, 2023
Merged

feat: use prometheus kurtosis package #399

merged 4 commits into from
Dec 12, 2023

Conversation

tedim52
Copy link
Contributor

@tedim52 tedim52 commented Dec 9, 2023 •
edited
Loading

Moves setup of prometheus server into a kurtosis package to simplify launch_prometheus logic. Now launch_prometheus logic only configures metrics jobs as opposed to configuring metrics jobs and configuring + starting a prometheus server.

I've verified this works by ensuring grafana dashboards are displaying metrics.

@tedim52 tedim52 changed the title feat: use prometheus package feat: use prometheus kurtosis package Dec 9, 2023
@barnabasbusa
Copy link
Contributor

Looks like it doesn't work for me locally:

ethereum-package git:(tedi/prometheus) kt run . --args-file .github/tests/mix-with-tools.yaml
INFO[2023-12-11T11:05:19+01:00] Creating a new enclave for Starlark to run inside... 
INFO[2023-12-11T11:05:20+01:00] Enclave 'looming-chasm' created successfully 
INFO[2023-12-11T11:05:20+01:00] Executing Starlark package at '/Users/bbusa/Documents/Ethereum.nosync/testnets/kurtosis/ethereum-package' as the passed argument '.' looks like a directory 
INFO[2023-12-11T11:05:20+01:00] Compressing package 'github.com/kurtosis-tech/ethereum-package' at '.' for upload 
INFO[2023-12-11T11:05:21+01:00] Uploading and executing package 'github.com/kurtosis-tech/ethereum-package' 
There was an error interpreting Starlark code 
Evaluation error: Multiple errors caught interpreting the Starlark script. Listing each of them below.
        at [github.com/kurtosis-tech/prometheus-package/main.star:44:41]: undefined: service_metrics_configs
        at [github.com/kurtosis-tech/ethereum-package/src/prometheus/prometheus_launcher.star:2:27]: <toplevel>
        at [github.com/kurtosis-tech/ethereum-package/src/beacon_metrics_gazer/beacon_metrics_gazer_launcher.star:2:27]: <toplevel>
        at [github.com/kurtosis-tech/ethereum-package/main.star:20:37]: <toplevel>

Error encountered running Starlark code.

@tedim52
Copy link
Contributor Author

tedim52 commented Dec 11, 2023

Ah my bad. Try again, I had to fix a typo in the prometheus-package

@barnabasbusa
Copy link
Contributor

@tedim52 could you resolve the conflict, then lets get this merged.

@tedim52 tedim52 merged commit c41a989 into main Dec 12, 2023
9 checks passed
@tedim52 tedim52 deleted the tedi/prometheus branch December 12, 2023 22:45
@github-actions github-actions bot mentioned this pull request Dec 12, 2023
Merged
barnabasbusa pushed a commit that referenced this pull request Jan 3, 2024
@github-actions
chore(main): release 1.2.0 (#380)
6a94574 
🤖 I have created a release *beep* *boop*
---


##
[1.2.0](1.1.0...1.2.0)
(2024-01-03)


### Features

* add blobber
([#401](#401))
([d2755b0](d2755b0))
* add files artifact uuid information to cl client context
([#418](#418))
([806ef47](806ef47))
* add graffiti
([#408](#408))
([21eae3b](21eae3b))
* add nethermind verkle example file
([#379](#379))
([244d1ee](244d1ee))
* add preregistered_validator_count network param field
([#426](#426))
([d598018](d598018))
* add prysm latency dashboard
([#397](#397))
([83b5b4e](83b5b4e))
* add resource requests/limits to most applications
([#396](#396))
([c5728d9](c5728d9))
* allow 0 genesis delay
([#383](#383))
([11c2693](11c2693))
* enable teku split beacon &lt;&gt; validator setup
([#409](#409))
([51f76bd](51f76bd))
* make eth1 follow distance configurable
([#433](#433))
([a40f7dc](a40f7dc))
* split nimbus CL-validator
([#404](#404))
([cb33648](cb33648))
* update ethereum-genesis-generator images
([#385](#385))
([8959fc8](8959fc8))
* use prometheus kurtosis package
([#399](#399))
([c41a989](c41a989))


### Bug Fixes

* ci was broken as it was using the wrong storage class for k3s
([#420](#420))
([f957f85](f957f85))
* enable debug namespace in prysm
([#405](#405))
([31badc2](31badc2))
* ethereum-genesis-generator version for verkle genesis
([#395](#395))
([d7c9b92](d7c9b92))
* fixing too long graffitis
([#410](#410))
([a18935f](a18935f))
* increase memory for blob spammer to prevent container from getting OOM
killed
([#431](#431))
([4d4fac0](4d4fac0))
* mev workflow
([#434](#434))
([91794e9](91794e9))
* mev-boost naming scheme change
([#428](#428))
([fce899b](fce899b))
* peering issue between lighthouse-teku on k8s
([#382](#382))
([97a070b](97a070b))
* peering issue with prysm and nimbus
([#416](#416))
([132fc83](132fc83))
* rename package icon for package catalog compatability
([#413](#413))
([f49185b](f49185b))
* roll out persistence for postgres on ethereum-package
([#421](#421))
([ed3982b](ed3982b))
* set persistence to false for blobscan
([#398](#398))
([3c06194](3c06194))
* tx-spammer extra args
([#394](#394))
([709b4ad](709b4ad))
* Update README.md remove teku coming soon
([#414](#414))
([5a1ce2e](5a1ce2e))
* validator counting
([#425](#425))
([698305a](698305a))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@barnabasbusa barnabasbusa barnabasbusa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tedim52 @barnabasbusa