Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: participant_network & rename participant fields. #508

Merged
merged 38 commits into from
Mar 8, 2024

Conversation

barnabasbusa
Copy link
Contributor

@barnabasbusa barnabasbusa commented Mar 5, 2024

Important!

There are many participant fields that have been renamed to be more consistent with the rest of the package. The following fields have been renamed:

EL Flags

el_client_type -> el_type
el_client_image -> el_image
el_client_log_level -> el_log_level
el_client_volume_size -> el_volume_size

CL Flags

cl_client_type -> cl_type
cl_client_image -> cl_image
cl_client_volume_size -> cl_volume_size
cl_client_log_level -> cl_log_level
beacon_extra_params -> cl_extra_params
beacon_extra_labels -> cl_extra_labels
bn_min_cpu -> cl_min_cpu
bn_max_cpu -> cl_max_cpu
bn_min_mem -> cl_min_mem
bn_max_mem -> cl_max_mem
use_separate_validator_client -> use_separate_vc

Validator flags

validator_client_type -> vc_type
validator_tolerations -> vc_tolerations
validator_client_image -> vc_image
validator_extra_params -> vc_extra_params
validator_extra_labels -> vc_extra_labels
v_min_cpu -> vc_min_cpu
v_max_cpu -> vc_max_cpu
v_min_mem -> vc_min_mem
v_max_mem -> vc_max_mem

Global flags

global_client_log_level -> global_log_level

Once this PR is merged, the old names will no longer work, and you will have to bulk rename all your yaml files.

A rename.sh bash script is added, which can be used to do bulk find and replace operations.

rename.sh yourFile.yaml

@barnabasbusa barnabasbusa linked an issue Mar 5, 2024 that may be closed by this pull request
@barnabasbusa barnabasbusa requested a review from h4ck3rk3y March 5, 2024 11:38
Base automatically changed from bbusa/gballet-local-snap to main March 5, 2024 13:06
@barnabasbusa barnabasbusa requested a review from h4ck3rk3y March 5, 2024 14:09
.github/tests/mixed-cl-vc.yml Outdated Show resolved Hide resolved
src/el/el_client_launcher.star Outdated Show resolved Hide resolved
src/network_launcher/public_network.star Outdated Show resolved Hide resolved
@barnabasbusa barnabasbusa changed the title refactor: participant_network refactor!: participant_network Mar 6, 2024
@barnabasbusa barnabasbusa changed the title refactor!: participant_network refactor!: participant_network & rename participant fields. Mar 7, 2024
@barnabasbusa barnabasbusa merged commit fab341b into main Mar 8, 2024
17 checks passed
@barnabasbusa barnabasbusa deleted the bbusa/refactoring branch March 8, 2024 11:20
barnabasbusa pushed a commit that referenced this pull request Mar 8, 2024
🤖 I have created a release *beep* *boop*
---


##
[2.0.0](1.4.0...2.0.0)
(2024-03-08)


### ⚠ BREAKING CHANGES

* participant_network & rename participant fields.
([#508](#508))
* add node selectors features
([#491](#491))

### Features

* add keymanager to all validator processes
([#502](#502))
([836eda4](836eda4))
* add nimbus-eth1
([#496](#496))
([d599729](d599729))
* add node selectors features
([#491](#491))
([316d42f](316d42f))
* allow more detailed additional test configurations in assertoor_params
([#498](#498))
([fe2de7e](fe2de7e))
* enable api in assertoor config
([#495](#495))
([9ceae9c](9ceae9c))
* enable dencun-genesis
([#500](#500))
([beb764f](beb764f))
* make snapshot url configurable
([#507](#507))
([6fa0475](6fa0475))
* parameterize mev-boost args
([#400](#400))
([e48483a](e48483a))
* separate validator clients from CL clients
([#497](#497))
([90da2c3](90da2c3))


### Bug Fixes

* fix end index in validator ranges file
([#509](#509))
([da55be8](da55be8))
* lh vc flag logic
([#506](#506))
([bc5e725](bc5e725))
* nimbus-eth1 advertise proper extip
([#501](#501))
([1d5a779](1d5a779))
* README global node selector
([#504](#504))
([f9343a2](f9343a2))
* use the cl as the default validator image if none are defined
([#503](#503))
([181dd04](181dd04))


### Code Refactoring

* participant_network & rename participant fields.
([#508](#508))
([fab341b](fab341b))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

refactor participant network
2 participants