Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confusing Documentation needs to be improved #42

Open
psovit opened this issue Jul 1, 2022 · 3 comments
Open

Confusing Documentation needs to be improved #42

psovit opened this issue Jul 1, 2022 · 3 comments
Labels
documentation Improvements or additions to documentation question Further information is requested

Comments

@psovit
Copy link

psovit commented Jul 1, 2022

The package's readme file says something about deprecation in AndroidManifest and Info.plist files.
However, it is not clear if the deprecated part is needed in latest versions (for eg: 3.9.0).

Also, looking at the latest example code, it is still using deprecated code.

Can you guys please update the documentation or the example?

Screen Shot 2022-07-01 at 17 36 09

@danielgomezrico danielgomezrico added the documentation Improvements or additions to documentation label Jul 1, 2022
@thorgexyz
Copy link

@danielgomezrico Can you give some clarification on whether those steps are still required or not here in this Thread?

@danielgomezrico
Copy link
Contributor

As far as I can understand this deprecated code still works and exists to maintain compatibility, the PR that introduced the setup via code is:

@danielgomezrico
Copy link
Contributor

@psovit have you tried without using the deprecated code to see what happens? please confirm to see if there's an issue or if the compatibility still works fine.

Deprecated means that it still works but will be removed in the future so I dont see any issue in the docs 🤓 , can you confirm that?

@danielgomezrico danielgomezrico added the question Further information is requested label Aug 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants