Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider updating rstest_macros to use Syn v2 #187

Closed
LikeLakers2 opened this issue Mar 20, 2023 · 1 comment · Fixed by #188
Closed

Consider updating rstest_macros to use Syn v2 #187

LikeLakers2 opened this issue Mar 20, 2023 · 1 comment · Fixed by #188

Comments

@LikeLakers2
Copy link

LikeLakers2 commented Mar 20, 2023

Hi! Syn v2 recently released. However, I notice you're still using Syn v1. Perhaps you could consider updating rstest_macros to use Syn v2?

Something to consider before doing so: Syn v2's new MSRV is Rust 1.56, moved up from Rust 1.31. Rust 1.56 was released in October 2021, making it a relatively old version. However, rstest does not appear to have an MSRV, not even with the rust-version Cargo.toml option - so I'm unsure what MSRV you intend rstest to have.

You may also have to edit some code to support some of the breaking changes that Syn v2 brings with it.

However, if neither of those are a problem to you, then consider changing your Syn dependency to depend on Syn v2.

@la10736
Copy link
Owner

la10736 commented Mar 20, 2023

Thx to report it. I'll do some experiments ASAP and 1.56 it's ok as MSRV. I don't think that the syn breaking changes can be an issue and maybe I'll also switch to 2021 edition.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants