Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More detail Session dependency checks #1746

Open
fregataa opened this issue Nov 28, 2023 · 0 comments
Open

More detail Session dependency checks #1746

fregataa opened this issue Nov 28, 2023 · 0 comments

Comments

@fregataa
Copy link
Member

fregataa commented Nov 28, 2023

Main idea

Currently, Session dependency check has only steps of checking "Sessions.result" column of depending sessions.
The value of result is SUCCESS if the session's main kernel finishes its batch job finish without any error.
Else, the result would be fail, which means the batch job occurs any error.

We could improve the dependency check logic to control session creation flow with conditions.
I suggest to implement like below.

  1. Add a condition field to the session dependency (or session) table. Receive it as a string that can be executed as a command in the kernel, and run as a command service in the kernel before the batch compute session ends. The command string parse and validation could be done in manager by adapting minilang. The result of this execution must be a SUCESS for the execution to be a success.
  2. It would be nice to have an on_fail in the condition as well, to cover the case where the execution result is fail (in general, if the batch session occurs any error).

Reference

Alternative ideas

No response

Anything else?

No response

@fregataa fregataa added the type:feature Add new features label Nov 28, 2023
@achimnol achimnol removed the type:feature Add new features label Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants