Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve remark parsing for Markdown #1

Closed
niftylettuce opened this issue Jan 10, 2020 · 2 comments
Closed

Improve remark parsing for Markdown #1

niftylettuce opened this issue Jan 10, 2020 · 2 comments

Comments

@niftylettuce
Copy link
Collaborator

Right now it parses all individual nodes, but we should probably parse paragraphs, headers, links, and blocks of text instead to properly respond with a formatted translation string to use. Otherwise translations aren't too accurate right now because of context.
@niftylettuce niftylettuce mentioned this issue Jan 10, 2020
Open
21 tasks
niftylettuce added a commit that referenced this issue Jan 10, 2020
@niftylettuce
feat: added markdown translation (rudimentary, see #1)
feb6a2f
@niftylettuce
Copy link
Collaborator Author

Copying @Flet on this!

@niftylettuce niftylettuce mentioned this issue Jan 16, 2020
Closed
@titanism
Copy link
Contributor

titanism commented Aug 31, 2022 •
edited
Loading

Fixed via 6159310. However nodes will still be broken apart if they contain <a> inside of them for example, a link inside of a paragraph will be split into three sections, the first part (content before the link), the link as the second part, and then the third part (content after the link).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@niftylettuce @titanism