Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make singleton types subtypes of their refined type #16135

Merged
merged 2 commits into from
Oct 3, 2022
Merged

Make singleton types subtypes of their refined type #16135

merged 2 commits into from
Oct 3, 2022

Conversation

mbovel
Copy link
Member

@mbovel mbovel commented Oct 3, 2022 •
edited by dwijnand
Loading

Fixes #10980

@mbovel mbovel marked this pull request as draft October 3, 2022 12:43
@mbovel mbovel force-pushed the mb/singleton-refined branch from 1931538 to 1eee2e0 Compare October 3, 2022 12:45
@mbovel mbovel linked an issue Oct 3, 2022 that may be closed by this pull request
A singleton type is not a subtype of its refined type #10980
Closed
@mbovel mbovel marked this pull request as ready for review October 3, 2022 14:26
@mbovel mbovel requested a review from odersky October 3, 2022 14:28
@dwijnand dwijnand changed the title Fix #10980 Make singleton types is not subtypes of their refined type Oct 3, 2022
@dwijnand dwijnand changed the title Make singleton types is not subtypes of their refined type Make singleton types subtypes of their refined type Oct 3, 2022
@mbovel mbovel requested a review from odersky October 3, 2022 17:06
odersky
odersky approved these changes Oct 3, 2022
View reviewed changes
Copy link
Contributor

@odersky odersky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mbovel mbovel merged commit 5d1497d into scala:main Oct 3, 2022
@mbovel mbovel deleted the mb/singleton-refined branch October 3, 2022 19:17
@Kordyjan Kordyjan added this to the 3.2.2 milestone Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@odersky odersky odersky approved these changes

Assignees

@odersky odersky

Labels
None yet
Projects
None yet
Milestone
3.2.2
Development

Successfully merging this pull request may close these issues.

A singleton type is not a subtype of its refined type
3 participants
@mbovel @odersky @Kordyjan