Fix #16173: SJS: Fix the detection of inferred types of = js.native.
#16184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not convinced this is the right fix, the code mentioned in the issue is if (tree.tpt.span.isSynthetic)
report.error(i"The type of ${tree.name} must be explicitly specified because it is JS native.", tree)If you want to check if the type was inferred, you should be able to do |
sjrd
force-pushed
the
sjs-native-with-literal-type
branch
from
a293cf6 to
488aa27
Compare
sjrd
changed the title
= js.native.
|
That is indeed a better fix, thanks. I've updated the PR. That said, is it still not wrong that literal type trees get a synthetic span? 🤔 |
|
I guess you could do |
smarter
reviewed
Oct 14, 2022
| @@ -981,7 +981,7 @@ class PrepJSInterop extends MacroTransform with IdentityDenotTransformer { thisP | |||
|
|
|||
| // Check that the resul type was explicitly specified | |||
There was a problem hiding this comment.
drive-by typo suggestion:
Suggested change
| // Check that the resul type was explicitly specified | |
| // Check that the result type was explicitly specified |
…tive`. Use `tpt.isInstanceOf[InferredTypeTree]` instead of relying on the span being synthetic.
sjrd
force-pushed
the
sjs-native-with-literal-type
branch
from
488aa27 to
63f96f0
Compare
smarter
approved these changes
Oct 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.