Fix approximateOr of (A & Double) | Null #16241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odersky
reviewed
Oct 24, 2022
dwijnand
changed the title
dwijnand
force-pushed
the
fix-handling-null-in-baseType
branch
from
754b68e to
8e5e7d0
Compare
dwijnand
commented
Oct 25, 2022
| def orBaseClasses(tp: Type): List[ClassSymbol] = tp.stripTypeVar match | ||
| case OrType(tp1, tp2) => | ||
| if tp1.isBottomType && (tp1 frozen_<:< tp2) then orBaseClasses(tp2) | ||
| else if tp2.isBottomType && (tp2 frozen_<:< tp1) then orBaseClasses(tp1) |
There was a problem hiding this comment.
Similar to e65305d (#11979)
noti0na1
reviewed
Oct 26, 2022
dwijnand
force-pushed
the
fix-handling-null-in-baseType
branch
from
8e5e7d0 to
36a9a9f
Compare
|
@dwijnand Nice cleanup ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[test_non_bootstrapped]