Fix the tparam bounds of exported inherited classes #18647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dwijnand
force-pushed
the
export-nested-class
branch
from
68905c1 to
b44edb5
Compare
dwijnand
force-pushed
the
export-nested-class
branch
from
6276d6e to
640e6c8
Compare
dwijnand
force-pushed
the
export-nested-class
branch
from
640e6c8 to
b0f9e16
Compare
odersky
reviewed
Nov 28, 2023
dwijnand
force-pushed
the
export-nested-class
branch
2 times, most recently
from
5d07e66 to
0b78b8e
Compare
odersky
requested changes
Jan 17, 2024
| @@ -1193,7 +1193,7 @@ class CompletionSuite extends BaseCompletionSuite: | |||
| | val x = Bar[M](new Foo[Int]{}) | |||
| | x.bar.m@@ | |||
| |""".stripMargin, | |||
| """|map[B](f: A => B): Foo[B] | |||
| """|map[B](f: Int => B): Foo[B] | |||
There was a problem hiding this comment.
Why is the test changed here?
There was a problem hiding this comment.
Because we've fixed the prefix, using x.bar : Foo[Int] instead of Foo[A].
dwijnand
force-pushed
the
export-nested-class
branch
from
0b78b8e to
846c9c6
Compare
|
Sorry for not coming back to this earlier. LGTM now. This should be merged after rebase. |
odersky
approved these changes
Feb 24, 2024
When trying to export M2.F, seeing M1#F from the prefix M2 doesn't change the bounds of F's T type parameter, which still refers to M1.this.A, rather than M2.A. So, we run asSeenFrom against that info, when eta-expanding the class into a hk type lambda.
When looking at the info of the type parameters of a TypeRef, make sure to honour the reference's prefix.
dwijnand
force-pushed
the
export-nested-class
branch
from
846c9c6 to
c9220c2
Compare
dwijnand
force-pushed
the
export-nested-class
branch
from
c9220c2 to
000de84
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to export M2.F, seeing M1#F from the prefix M2 doesn't
change the bounds of F's T type parameter, which still refers to
M1.this.A, rather than M2.A. So, we run asSeenFrom against that info,
when eta-expanding the class into a hk type lambda.