Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix parsing of conditional expressions in parentheses #19985

Merged
merged 1 commit into from
Mar 20, 2024
Merged

Fix parsing of conditional expressions in parentheses #19985

merged 1 commit into from
Mar 20, 2024

Conversation

odersky
Copy link
Contributor

@odersky odersky commented Mar 20, 2024

We overlooked that the first parenthesized expression might be a tuple.

See https://users.scala-lang.org/t/parsing-conditionals/9888

@odersky
Fix parsing of conditional expressions in parentheses
767fc35 
We overlooked that the first parenthesized expression might be a tuple.

See https://users.scala-lang.org/t/parsing-conditionals/9888
@odersky odersky requested a review from hamzaremmal March 20, 2024 07:41
@hamzaremmal hamzaremmal merged commit 0ea0eba into scala:main Mar 20, 2024
19 checks passed
@hamzaremmal hamzaremmal deleted the fix-condexpr-parse branch March 20, 2024 09:17
@SethTisue SethTisue added the backport:nominated If we agree to backport this PR, replace this tag with "backport:accepted", otherwise delete it. label Mar 20, 2024
@Kordyjan Kordyjan added this to the 3.4.2 milestone Mar 28, 2024
@WojciechMazur WojciechMazur mentioned this pull request Jul 3, 2024
Merged
WojciechMazur added a commit that referenced this pull request Jul 4, 2024
@WojciechMazur
Backport "Fix parsing of conditional expressions in parentheses" to L…
6be74d3 
…TS (#21006)

Backports #19985 to the LTS branch.

PR submitted by the release tooling.
[skip ci]
@WojciechMazur WojciechMazur removed the backport:nominated If we agree to backport this PR, replace this tag with "backport:accepted", otherwise delete it. label Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hamzaremmal hamzaremmal hamzaremmal approved these changes

Assignees

@hamzaremmal hamzaremmal

Labels
None yet
Projects
None yet
Milestone
3.4.2
Development

Successfully merging this pull request may close these issues.
5 participants
@odersky @hamzaremmal @SethTisue @Kordyjan @WojciechMazur