Improve reporting in staging about the possible use of an incorrect class loader #20137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jchyb
force-pushed
the
fix-staging-classloader-reporting
branch
from
2d5c41c to
01e09c0
Compare
|
|
jchyb
force-pushed
the
fix-staging-classloader-reporting
branch
from
01e09c0 to
59b0c07
Compare
jchyb
force-pushed
the
fix-staging-classloader-reporting
branch
from
59b0c07 to
7b8d825
Compare
jchyb
force-pushed
the
fix-staging-classloader-reporting
branch
from
7b8d825 to
7e84497
Compare
* do not println staging crashes to stdout * enrich the errors coming from the compiler with additional hints about using the correct classloader
jchyb
force-pushed
the
fix-staging-classloader-reporting
branch
from
7e84497 to
b9c7cad
Compare
nicolasstucki
approved these changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Hopefully) closes #19170 and #19176 and extends the changes from #19428
I do not really think it's possible to comprehensively check whether the class loader that is being passed into the staging.compiler is the correct one or not, so instead I tried improving the reporting here (like in the previous PR above) coming from the compiler, so that:
@nicolasstucki what do you think about this? I don't really know what else we can do for those 2 issues