Fix active param index for empty param lists #20142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iusildra
commented
Apr 9, 2024
presentation-compiler/src/main/dotty/tools/pc/SignatureHelpProvider.scala
Outdated
Show resolved
Hide resolved
rochala
reviewed
Apr 9, 2024
| @@ -70,7 +70,7 @@ object SignatureHelpProvider: | |||
| new l.SignatureHelp( | |||
| signatureInfos.map(signatureToSignatureInformation).asJava, | |||
| callableN, | |||
| paramN | |||
| if signatureInfos.isEmpty then null else paramN | |||
There was a problem hiding this comment.
Ahh, I see why it worked with null on my setup.
This method will never return null if there is at least a single signature present.
I can now confirm that null indeed is not working, and the solution is -1 so
you should change this back to just paramN
There was a problem hiding this comment.
Okay, will push the true fix this evening ^^
rochala
approved these changes
Apr 9, 2024
WojciechMazur
pushed a commit
that referenced
this pull request
Jul 5, 2024
Fixes #19969 with @mbovel @rochala --------- Co-authored-by: Lucas Nouguier <[email protected]> [Cherry-picked adf089b]
WojciechMazur
added a commit
that referenced
this pull request
Jul 5, 2024
Backports #20142 to the LTS branch. PR submitted by the release tooling. [skip ci]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19969 with @mbovel @rochala