Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set default source version to 3.5 #20435

Merged
merged 2 commits into from
May 27, 2024
Merged

Set default source version to 3.5 #20435

merged 2 commits into from
May 27, 2024

Conversation

odersky
Copy link
Contributor

@odersky odersky commented May 19, 2024 •
edited
Loading

The main part of this branch was superseded by #20441, but there were a couple of tests to add, and also a change
in the treatment of looping implicits in 3.6

@hamzaremmal hamzaremmal self-assigned this May 19, 2024
@odersky
Copy link
Contributor Author

odersky commented May 19, 2024

We should add a note to the process that when we first increase the minor version number, the defaultSourceVersion field in SourceVersion has to be updated as well.

@hamzaremmal hamzaremmal mentioned this pull request May 20, 2024
Merged
@odersky
Copy link
Contributor Author

odersky commented May 21, 2024

@hamzaremmal I added you to dotty-staging/dotty. So in the future you can push your PRs there or add commits to existing PRs.

hamzaremmal added a commit that referenced this pull request May 27, 2024
@hamzaremmal
Set default source version to 3.5 (#20441)
a594958 
Superseeds #20435 
Closes #20415 

[test_scala2_library_tasty]
[test_windows_full]
[test_java8]
@odersky odersky requested a review from hamzaremmal May 27, 2024 14:33
@odersky
Copy link
Contributor Author

odersky commented May 27, 2024

@hamzaremmal Please review

@hamzaremmal hamzaremmal enabled auto-merge May 27, 2024 15:08
@hamzaremmal hamzaremmal merged commit 5187735 into scala:main May 27, 2024
16 checks passed
@hamzaremmal hamzaremmal deleted the fix-20415 branch May 27, 2024 17:19
@Kordyjan Kordyjan added this to the 3.5.1 milestone Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hamzaremmal hamzaremmal hamzaremmal approved these changes

Assignees

@hamzaremmal hamzaremmal

Labels
None yet
Projects
None yet
Milestone
3.5.1
Development

Successfully merging this pull request may close these issues.
3 participants
@odersky @hamzaremmal @Kordyjan