Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Bump mtags to latest stable #20442

Merged
merged 1 commit into from
May 21, 2024
Merged

Conversation

tgodzik
Copy link
Contributor

@tgodzik tgodzik commented May 21, 2024

We should avoid using non stable versions since this can cause issues like scalameta/metals#6402

Closes scalameta/metals#6402

@tgodzik tgodzik requested a review from rochala May 21, 2024 12:25
@@ -1335,7 +1335,8 @@ object Build {
BuildInfoPlugin.buildInfoDefaultSettings

lazy val presentationCompilerSettings = {
val mtagsVersion = "1.3.0+56-a06a024d-SNAPSHOT"
// Avoid bumping to snapshot since it's in a different repository than maven central
val mtagsVersion = "1.3.1"

Seq(
resolvers ++= Resolver.sonatypeOssRepos("snapshots"),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to comment, are we going to stop using nightly here ? If so lets remove this line.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed, good idea!

@tgodzik tgodzik force-pushed the bump-to-stable branch 2 times, most recently from 46faece to 8a01d65 Compare May 21, 2024 13:06
We should avoid using non stable versions since this can cause issues like scalameta/metals#6402

Closes scalameta/metals#6402
@tgodzik tgodzik merged commit a21cd82 into scala:main May 21, 2024
19 checks passed
@tgodzik tgodzik deleted the bump-to-stable branch May 21, 2024 15:36
@Kordyjan Kordyjan added this to the 3.5.1 milestone Jul 3, 2024
WojciechMazur added a commit that referenced this pull request Jul 8, 2024
Backports #20442 to the LTS branch.

PR submitted by the release tooling.
[skip ci]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scala 3.4.1 apparently unsupported in metals, behind corporate proxy
3 participants