Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error related to reaches when using scala2-library-cc-tasty #20528

Merged
merged 1 commit into from
Jun 6, 2024

Conversation

noti0na1
Copy link
Member

@noti0na1 noti0na1 commented Jun 6, 2024

Fix error introduced by a test of #20524

Due to limitation in expressiveness of current system, we are not able to map over lists of impure elements.

See discussion in #20156

[test_scala2_library_tasty]

@Linyxus
Copy link
Contributor

Linyxus commented Jun 6, 2024

thanks! I think due to the design of the current system, there ought to be an error on this line. It is a bit weird that with non-capture-checked list the error is not issued, though.

@noti0na1 noti0na1 marked this pull request as ready for review June 6, 2024 12:37
@noti0na1 noti0na1 requested review from odersky and Linyxus June 6, 2024 12:37
Copy link
Contributor

@Linyxus Linyxus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great to me!

@noti0na1
Copy link
Member Author

noti0na1 commented Jun 6, 2024

It is a bit weird that with non-capture-checked list the error is not issued, though.

The universal capability in the type signature of non-cc list is replaced by fluid capability, so there is no error.

@noti0na1 noti0na1 merged commit 27a3f80 into scala:main Jun 6, 2024
19 checks passed
@noti0na1 noti0na1 deleted the fix-reaches-test branch June 6, 2024 15:26
@Kordyjan Kordyjan added this to the 3.5.1 milestone Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants