Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More principled filtering of abstract values in initialization check #20548

Merged
merged 3 commits into from
Jun 14, 2024

Conversation

liufengyun
Copy link
Contributor

More principled filtering of abstract values in initialization check.

It ports the similar improvement to the global initialization checker #19612.

@olhotak
Copy link
Contributor

olhotak commented Jun 10, 2024

Could some of this be factored out so that functionality can be shared between Objects.scala and Semantic.scala? Or are there fundamental differences?

@liufengyun
Copy link
Contributor Author

Could some of this be factored out so that functionality can be shared between Objects.scala and Semantic.scala? Or are there fundamental differences?

It's a little difficult to share, because the abstract values are different.

Copy link
Contributor

@olhotak olhotak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM.

tests/init/warn/type-filter2.scala Outdated Show resolved Hide resolved
Co-authored-by: Ondřej Lhoták <[email protected]>
@liufengyun liufengyun enabled auto-merge June 14, 2024 20:40
@liufengyun liufengyun merged commit fcb0a3f into scala:main Jun 14, 2024
23 checks passed
@liufengyun liufengyun deleted the fengyun/init-check-type-filter branch June 14, 2024 21:18
@Kordyjan Kordyjan added this to the 3.5.1 milestone Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants