Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid jpath in example #20775

Merged
merged 3 commits into from
Jun 25, 2024
Merged

Avoid jpath in example #20775

merged 3 commits into from
Jun 25, 2024

Conversation

som-snytt
Copy link
Contributor

Fixes #20591

[skip ci]

@Gedochao Gedochao requested a review from bishabosha June 25, 2024 08:01
bishabosha
bishabosha requested changes Jun 25, 2024
View reviewed changes
Copy link
Member

@bishabosha bishabosha left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest to highlight getJPath as that still returns Option[java.nio.file.Path], then show path (returning String) as a fallback if you don't care if its virtual

@bishabosha bishabosha assigned som-snytt and unassigned bishabosha Jun 25, 2024
@som-snytt
Copy link
Contributor Author

I wouldn't do it that way, since the path is available as a string. But I'm not one to stand in the way of anything.

@bishabosha
Copy link
Member

Yeah I guess others might prefer to fail at runtime if you require the path to exist.

@bishabosha bishabosha merged commit 3bd31c0 into scala:main Jun 25, 2024
24 checks passed
@som-snytt som-snytt deleted the tweak/reflect-example branch June 25, 2024 10:12
@Kordyjan Kordyjan added this to the 3.5.1 milestone Jul 3, 2024
@WojciechMazur WojciechMazur mentioned this pull request Jul 9, 2024
Merged
WojciechMazur added a commit that referenced this pull request Jul 10, 2024
@WojciechMazur
Backport "Avoid jpath in example" to LTS (#21146)
f28d68c 
Backports #20775 to the LTS branch.

PR submitted by the release tooling.
[skip ci]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bishabosha bishabosha bishabosha approved these changes

Assignees

@som-snytt som-snytt

Labels
None yet
Projects
None yet
Milestone
3.5.1
Development

Successfully merging this pull request may close these issues.

Issue with macros and in-memory (virtual) source files
3 participants
@som-snytt @bishabosha @Kordyjan