Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark genSJSIR as *disabled* (rather than non-*runnable*) when no -scalajs. #20815

Merged
merged 1 commit into from
Jun 28, 2024
Merged

Mark genSJSIR as *disabled* (rather than non-*runnable*) when no -scalajs. #20815

merged 1 commit into from
Jun 28, 2024

Conversation

sjrd
Copy link
Member

@sjrd sjrd commented Jun 26, 2024

This works around the issue seen in #20296. However, the issue resurfaces if we actually run -Ycheck:all in a Scala.js-enabled build.

@sjrd sjrd requested a review from aherlihy June 26, 2024 11:56
@sjrd sjrd force-pushed the workaround-i20296 branch from 3fea8a0 to 0f753ab Compare June 27, 2024 14:55
@sjrd sjrd linked an issue Jun 27, 2024 that may be closed by this pull request
Assertion failed "class defined twice" with testCompilation #20296
Closed
@sjrd
Mark genSJSIR as *disabled* (rather than non-*runnable*) when no `-sc…
a88312b 
…alajs`.

This works around the issue seen in scala#20296. However, the issue
resurfaces if we actually run `-Ycheck:all` in a Scala.js-enabled
build.
@sjrd sjrd force-pushed the workaround-i20296 branch from 0f753ab to a88312b Compare June 28, 2024 07:49
@sjrd sjrd enabled auto-merge June 28, 2024 07:51
@sjrd sjrd merged commit fff4ee6 into scala:main Jun 28, 2024
21 checks passed
@sjrd sjrd deleted the workaround-i20296 branch June 28, 2024 09:12
@Kordyjan Kordyjan added this to the 3.5.1 milestone Jul 3, 2024
@WojciechMazur WojciechMazur mentioned this pull request Jul 10, 2024
Merged
WojciechMazur added a commit that referenced this pull request Jul 10, 2024
@WojciechMazur
Backport "Mark genSJSIR as *disabled* (rather than non-*runnable*) wh…
132467a 
…en no `-scalajs`." to LTS (#21150)

Backports #20815 to the LTS branch.

PR submitted by the release tooling.
[skip ci]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aherlihy aherlihy aherlihy approved these changes

Assignees

@aherlihy aherlihy

Labels
None yet
Projects
None yet
Milestone
3.5.1
Development

Successfully merging this pull request may close these issues.

Assertion failed "class defined twice" with testCompilation
3 participants
@sjrd @aherlihy @Kordyjan