[6.0] Bug Redis queue

[janakaedirisinghe]

Laravel Version: 6.0.3
PHP Version: 7.3
Database Driver & Version: mariadb / Redis 5.0.5 / phpredis

Description:

I had a couple of queue jobs failed in Horizon (with redis) and when I resubmitted them via Horizon I got an error from Bugsnag. This wont stop until I restarted the Horizon worker...

https://github.com/laravel/framework/blob/6.x/src/Illuminate/Queue/RedisQueue.php#L230

/src/Illuminate/Queue/RedisQueue.php:230

[$job, $reserved] = $nextJob;

ErrorException Undefined offset: 1 
    /home/test/releases/341/vendor/laravel/framework/src/Illuminate/Queue/RedisQueue.php:230 Illuminate\Foundation\Bootstrap\HandleExceptions::handleError
    /home/test/releases/341/vendor/laravel/framework/src/Illuminate/Queue/RedisQueue.php:230 Illuminate\Queue\RedisQueue::retrieveNextJob
    /home/test/releases/341/vendor/laravel/framework/src/Illuminate/Queue/RedisQueue.php:169 Illuminate\Queue\RedisQueue::pop
    /home/test/releases/341/vendor/laravel/horizon/src/RedisQueue.php:92 Laravel\Horizon\RedisQueue::pop
    /home/test/releases/341/vendor/laravel/framework/src/Illuminate/Queue/Worker.php:264 Illuminate\Queue\Worker::getNextJob
    /home/test/releases/341/vendor/laravel/framework/src/Illuminate/Queue/Worker.php:118 Illuminate\Queue\Worker::daemon
    /home/test/releases/341/vendor/laravel/framework/src/Illuminate/Queue/Console/WorkCommand.php:112 Illuminate\Queue\Console\WorkCommand::runWorker
    /home/test/releases/341/vendor/laravel/framework/src/Illuminate/Queue/Console/WorkCommand.php:96 Illuminate\Queue\Console\WorkCommand::handle
    /home/test/releases/341/vendor/laravel/horizon/src/Console/WorkCommand.php:46 Laravel\Horizon\Console\WorkCommand::handle
    [internal] call_user_func_array
    /home/test/releases/341/vendor/laravel/framework/src/Illuminate/Container/BoundMethod.php:32 Illuminate\Container\BoundMethod::Illuminate\Container\{closure}
    /home/test/releases/341/vendor/laravel/framework/src/Illuminate/Container/BoundMethod.php:90 Illuminate\Container\BoundMethod::callBoundMethod
    /home/test/releases/341/vendor/laravel/framework/src/Illuminate/Container/BoundMethod.php:34 Illuminate\Container\BoundMethod::call
    /home/test/releases/341/vendor/laravel/framework/src/Illuminate/Container/Container.php:591 Illuminate\Container\Container::call
    /home/test/releases/341/vendor/laravel/framework/src/Illuminate/Console/Command.php:192 Illuminate\Console\Command::execute
    /home/test/releases/341/vendor/symfony/console/Command/Command.php:255 Symfony\Component\Console\Command\Command::run
    /home/test/releases/341/vendor/laravel/framework/src/Illuminate/Console/Command.php:179 Illuminate\Console\Command::run
    /home/test/releases/341/vendor/symfony/console/Application.php:915 Symfony\Component\Console\Application::doRunCommand
    /home/test/releases/341/vendor/symfony/console/Application.php:272 Symfony\Component\Console\Application::doRun
    /home/test/releases/341/vendor/symfony/console/Application.php:148 Symfony\Component\Console\Application::run
    /home/test/releases/341/vendor/laravel/framework/src/Illuminate/Console/Application.php:90 Illuminate\Console\Application::run
    /home/test/releases/341/vendor/laravel/framework/src/Illuminate/Foundation/Console/Kernel.php:131 Illuminate\Foundation\Console\Kernel::handle
    /home/test/releases/341/artisan:37 [main]

[it-can]

I sometimes have the same issue... #29969

[driesvints]

Did you updated your code? You should always restart horizon when code changes during deployment.

[it-can]

For me it seems to happen after a job has failed. With or without horizon I get this error sometimes

[driesvints]

@it-can did you try one of the support channels like I asked in the issue?

[it-can]

there are multiple people now also having this issue. It seems to happen on v6 on laravel, before no problems at all with 5.6 - 5.8 for me... Nothing changed in my queue jobs whatsoever, only upgraded to v6. Also happens with Horizon or without Horizon... Have multiple projects that generate this error when a job fails and is resubmitted I think...

[driesvints]

@it-can can you please try on a support channel first?

[it-can]

nevermind

[cloud-arrow]

This problem has not been fixed in the 6.x branch, can you still release the version here?
@driesvints @taylorotwell

https://github.com/laravel/framework/blob/6.x/src/Illuminate/Redis/Connections/PhpRedisConnection.php#L515

[driesvints]

@cloud-arrow 6.x isn't supported anymore sorry. Please upgrade to v10