Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LongWait notification specifies exact queue #1171

Closed
jasonmccreary opened this issue Aug 4, 2022 · 1 comment
Closed

LongWait notification specifies exact queue #1171

jasonmccreary opened this issue Aug 4, 2022 · 1 comment
Assignees

Comments

@jasonmccreary
Copy link
Contributor

jasonmccreary commented Aug 4, 2022

When specifying multiple queues for a process, the LongWait notifications must be configured using the queue names concatenated with a comma (,). While it made sense after the fact, my initial inclination was to specify the individual queue inline with the example (e.g. connection:queue).

More importantly, when receiving the notification, the queue uses the concatenated name. This doesn't immediately let me know which queue has the long wait. Ideally, the notification would specify the individual queue which has the long wait.

Current behavior

Example configuration:

    'waits' => [
        // ...
        'redis:automation,subscriber,paid,workbench' => 1800,
    ],

    // ...

    'environments' => [
        'worker' => [
            'shifts' => [
                // ...
                'queue' => ['automation', 'subscriber', 'paid', 'workbench'],
                'balance' => false,
            ],
        ],
    ],

The notification states:

The "automation,subscriber,paid,workbench" queue on the "redis" connection has a wait time of 62 seconds.

Desired behavior

Ideally you could configure the waits by the individual queue:

    'waits' => [
        // ...
        'redis:automation' => 1800,
    ],

    // ...

    'environments' => [
        'worker' => [
            'shifts' => [
                // ...
                'queue' => ['automation', 'subscriber', 'paid', 'workbench'],
                'balance' => false,
            ],
        ],
    ],

And the notification would specify the wait time for the specific queue:

The "automation" queue on the "redis" connection has a wait time of 1803 seconds.


If this is an acceptable change, I'm glad to help work on it as I already dug around the code a bit to better understand how to configure the waits.

@taylorotwell
Copy link
Member

Hey @jasonmccreary - sure feel free to send something over for us to review if you have time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants