Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish assets with Composer hook #594

Closed
driesvints opened this issue Mar 21, 2019 · 1 comment
Closed

Publish assets with Composer hook #594

driesvints opened this issue Mar 21, 2019 · 1 comment

Comments

@driesvints
Copy link
Member

Like laravel/horizon#554 it should also be possible for Telescope to publish updated assets after a composer dependency update. Telescope will need to add its own assets command for this.

@barryvdh
Copy link
Contributor

An alternative to this could be:

  • Render the assets inline (downside: no caching, loaded each request but not so big an issue because it's loaded only on the first request)
  • Pass the assets through the API (eg /telescope/assets/script.js -> AssetController@getScriptJs`, which could set a TTL for browser caching)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants