Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Login within Bottom Bar / VsCode #22

Open
larkinds opened this issue Feb 18, 2021 · 2 comments
Open

Login within Bottom Bar / VsCode #22

larkinds opened this issue Feb 18, 2021 · 2 comments
Labels
stretch goal not easily doable, but a good idea

Comments

@larkinds
Copy link
Owner

Keep entire authentication process within VScode

@jkmartindale
Copy link
Collaborator

If I remember our conversation correctly from yesterday, this goal is to open a pop-up login window inside of VS Code instead of in a web browser. I just realized that the browser has a few advantages:

  • If the user is already logged in, they'll be fast-tracked to the consent form
  • Once a user logs in, they'll be remembered for future authorization sessions (assuming they don't log out)
  • The browser could have things making it easier to log in, e.g. password managers or browser autofill

A lot of user preference lives in the browser. We lose all of these advantages once we pop a webview in VS Code instead.

The main issue with browser auth, the ugly success page, is fixed by #26, so this issue isn't as necessary anyway.

@jkmartindale
Copy link
Collaborator

Then again, Karan suggested this during pod demos today. So maybe this is something that users would expect anyway, and I'm wrong to think user preference is the browser.

@larkinds larkinds changed the title Stetch Goal: Login within Bottom Bar / VsCode Login within Bottom Bar / VsCode Mar 1, 2021
@larkinds larkinds added the stretch goal not easily doable, but a good idea label Mar 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stretch goal not easily doable, but a good idea
Projects
None yet
Development

No branches or pull requests

2 participants