Tailwind Header #91
Open
Tailwind Header #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larkinds
requested changes
Jan 12, 2024
client/src/Components/Header.tsx
Outdated
| <Link to="/" onClick={() => handleSetStarPage("/")}><IceCreamLogo />Randomice</Link> | ||
| <header className="w-full flex justify-between items-center h-[100px] px-4 mt-4"> | ||
| <Link to="/"> | ||
| <div className="flex items-center justify-center mb-2"> |
There was a problem hiding this comment.
It looks uneven to have the Randomice text on a different horizontal line than all of the rest of the text in the header. Shall we remove it?
| <CartPage /> | ||
| <button className="ml-2.5 mr-2.5 hover:underline">login/logout</button> |
There was a problem hiding this comment.
Pls have only the relevant word visible - either Login or Logout, depending on whether the customer is logged in or not!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #84 by incorporating Tailwind styling and Navlink from React Router