fix: offline mode would spam logs when file changes #406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwaldren-ld
force-pushed
the
cw/offline-mode-spammy-log-v8
branch
from
283f334 to
27093cb
Compare
tanderson-ld
approved these changes
Jun 25, 2024
kinyoklion
approved these changes
Jun 25, 2024
cwaldren-ld
pushed a commit
that referenced
this pull request
Jun 25, 2024
🤖 I have created a release *beep* *boop* --- ## [8.8.0](v8.7.1...v8.8.0) (2024-06-25) ### Features * offline mode key rotation ([#408](#408)) ([b3f03a4](b3f03a4)) * periodic key revocation ([#401](#401)) ([92033e9](92033e9)) ### Bug Fixes * offline mode would spam logs when file changes ([#406](#406)) ([3c12e10](3c12e10)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the offline mode archive changed for the first time, the file monitor would emit a spurious log subsequent times because it wasn't updating its cache of the latest info from
stat.I've also extracted some of the log messages into
conststrings to fit the existing paradigm.