fix: redact password in logs if specified as part of URL #413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sheenacarswell
requested review from
a team,
keelerm84,
cwaldren-ld and
kinyoklion
cwaldren-ld
reviewed
Jul 10, 2024
cwaldren-ld
changed the title
cwaldren-ld
force-pushed
the
sheena/sc-249267/redact-password-in-logs
branch
from
de9d2e0 to
96ce70c
Compare
cwaldren-ld
approved these changes
Jul 12, 2024
cwaldren-ld
pushed a commit
that referenced
this pull request
Jul 16, 2024
🤖 I have created a release *beep* *boop* --- ## [8.8.2](v8.8.1...v8.8.2) (2024-07-15) ### Bug Fixes * redact password in logs if specified as part of URL ([#413](#413)) ([0471d51](0471d51)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
keelerm84
pushed a commit
that referenced
this pull request
Jul 25, 2024
**Requirements** - [x] I have added test coverage for new or changed functionality - [x] I have followed the repository's [pull request submission guidelines](../blob/master/CONTRIBUTING.md#submitting-pull-requests) - [x] I have validated my changes against all supported platform versions **Related issues** (Internal: see sc-249267) **Describe the solution you've provided** When the connection URL is specified with a username and password, this was logged in full, for example "Using proxy server at http://my-user-name:my-password@my-proxy-server". This fix redacts any password specified as part of the URL from the logs.
keelerm84
pushed a commit
that referenced
this pull request
Jul 25, 2024
🤖 I have created a release *beep* *boop* --- ## [8.8.2](v8.8.1...v8.8.2) (2024-07-15) ### Bug Fixes * redact password in logs if specified as part of URL ([#413](#413)) ([0471d51](0471d51)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Related issues
(Internal: see sc-249267)
Describe the solution you've provided
When the connection URL is specified with a username and password, this was logged in full, for example "Using proxy server at http://my-user-name:my-password@my-proxy-server". This fix redacts any password specified as part of the URL from the logs.