fix: Mitigate web cache poisoning for /sdk/goals endpoint
#475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Despite the name, only a small subset of the relay proxy is actually a proxy. Client SDKs communicating with the `/sdk/goals` endpoint rely on a reverse proxy to our upstream endpoints. These requests make use of a caching transport as a way to try and reduce traffic. This cache was keyed solely on the request path, allowing a malicious actor to "poison" the cache by making a request with a valid `If-None-Match` header. The proxy would pass through the request as is, receive a `304 NOT MODIFIED` from upstream, then dutifully cache the response. When a subsequent request came through, even without the `If-None-Match` header, the cached response would be loaded, the previously seen `ETag` header would be loaded and sent forward, resulting in an invalid `304 NOT MODIFIED` response. To mitigate this, we are removing the intermediate caching transport. Removing this seemingly would increase traffic to our upstream endpoints as we are removing a caching layer. However, the `/sdk/goals` endpoint returns a `Cache-Control: max-age=0`, which undermined the original intent of the caching transport. As a result, all calls are being directly proxied regardless.
alsmola
approved these changes
Feb 5, 2025
kinyoklion
approved these changes
Feb 5, 2025
keelerm84
pushed a commit
that referenced
this pull request
Feb 5, 2025
🤖 I have created a release *beep* *boop* --- ## [8.10.6](v8.10.5...v8.10.6) (2025-02-05) ### Bug Fixes * **deps:** bump supported Go versions to 1.23.6 and 1.22.12 ([#476](#476)) ([1ce9396](1ce9396)) * **deps:** update Dockerfiles from 3.21.0 to alpine:3.21.1 ([#470](#470)) ([5b7a450](5b7a450)) * **deps:** update Dockerfiles from 3.21.1 to alpine:3.21.2 ([#472](#472)) ([580c48f](580c48f)) * Mitigate web cache poisoning for `/sdk/goals` endpoint ([#475](#475)) ([a6ee692](a6ee692)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.