Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Event:sudo is not correct #55

Closed
cjunge-work opened this issue Apr 26, 2017 · 1 comment
Closed

Event:sudo is not correct #55

cjunge-work opened this issue Apr 26, 2017 · 1 comment

Comments

@cjunge-work
Copy link

On line https://github.com/lavary/crunz/blob/master/src/Event.php#L200 there is a call to $this->sudo(), but the definition at https://github.com/lavary/crunz/blob/master/src/Event.php#L222-L225 is protected function sudo($user) with the $user parameter being used.

Also, on https://github.com/lavary/crunz/blob/master/src/Event.php#L207 the call to sudo() is not appended to the $command, so nothing will happen with the returned value.

I believe that sudo() should use $this->user as the value and that https://github.com/lavary/crunz/blob/master/src/Event.php#L207 should append it to $command

@PabloKowalczyk
Copy link
Collaborator

You are right. Fixed in #85, thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants