Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release prebuilt binaries #129

Closed
ngocdaothanh opened this issue Sep 5, 2019 · 2 comments
Closed

Release prebuilt binaries #129

ngocdaothanh opened this issue Sep 5, 2019 · 2 comments

Comments

@ngocdaothanh
Copy link

ngocdaothanh commented Sep 5, 2019

node-gyp is used for building isolated-vm:
https://github.com/nodejs/node-gyp

But node-gyp doesn't support Python 3.

When isolated-vm is used inside other libraries, when users install other libraries, the installation will fail because most users don't have Python 2.

Can isolated-vm release prebuilt binaries like this please?
https://github.com/atom/node-keytar/releases/tag/v4.13.0

@laverdet
Copy link
Owner

laverdet commented Sep 5, 2019

Sorry, I don't want to do this. I do this for node-fibers and it's been a total nightmare. Supposedly gyp works on python 3 and we're just waiting for support from node-gyp. This is being tracked on nodejs/node-gyp#1687 which you I notice you commented on 2 days ago. Anyway, for now python 2 is needed for binary modules on nodejs, that's just the reality of it.

@laverdet laverdet closed this as completed Sep 5, 2019
@ngocdaothanh
Copy link
Author

But node-gyp doesn't support Python 3.

Memo: node-gyp now supports Python 3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants